On Tue, Jun 21, 2011 at 5:10 AM, Ivana Hutarova Varekova
<varek...@redhat.com> wrote:
> In a special case the lock in config_order_namespace_table function in config 
> is not unlocked this patch fixes it.
>
> Signed-off-by: Ivana Hutarova Varekova <varek...@redhat.com>
> ---
>
>  src/config.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/src/config.c b/src/config.c
> index 3e67b4f..261b2a0 100644
> --- a/src/config.c
> +++ b/src/config.c
> @@ -725,8 +725,10 @@ static int config_order_namespace_table(void)
>                                }
>                        }
>                }
> -               if (!flag)
> +               if (!flag) {
>                        return ECGNAMESPACECONTROLLER;
> +                       pthread_rwlock_unlock(&cg_mount_table_lock);
> +               }

so, can we redo this as,

ret/err = ECGNAMESPACECONTROLLER;
goto error_out;

(don't remember whether it is ret/error we use there, and don't have
code handy.) (In any case, the way the patch is right now, it won't
work still :-) )

Thanks,
Dhaval

------------------------------------------------------------------------------
EditLive Enterprise is the world's most technically advanced content
authoring tool. Experience the power of Track Changes, Inline Image
Editing and ensure content is compliant with Accessibility Checking.
http://p.sf.net/sfu/ephox-dev2dev
_______________________________________________
Libcg-devel mailing list
Libcg-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libcg-devel

Reply via email to