On 07/07/2011 09:26 PM, Dhaval Giani wrote: > Hi, > > On Thu, Jul 7, 2011 at 1:12 AM, Nikiforov Alex<a.nikifo...@samsung.com> > wrote: >> Dear colleagues, >> >> I'm engineer of Samsung Russia Center's Software Lab. >> We would like to use libcgroups to control our applications' performance and >> contribute to the development process to increase performance and usability. >> Let me to introduce small patch for the libcgroup as an initial point of >> cooperation. >> > > Welcome to the project! > >> The patch targeted to enhance performance of high-load embedded systems: >> >> 1) Eliminates syscalls when PID is invalid. >> 2) Changes standart read()/write() to readv()/writev(). >> 3) Replaces 2 syscalls with one vector-based. >> > > Sounds good. Do you also have some performance numbers? ( I am just > curious about it, its not a blocker)
Dont have numbers for this particular case, but have some experience with high load embedded devices >> Please review the patch and share your opinion - does it worth to implement >> and how can we contribute to libcgroup development? > > As I mentioned in the patch review, I would expect 3 patches (as > opposed to one single one), and you would need to follow the kernel > DCO, https://lwn.net/Articles/139918/ (see point 11) and the kernel > codingstyle (There is a nice script called checkpatch.pl in kernel > sources, > (http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=scripts/checkpatch.pl;h=b0aa2c680593d0c09857b9447d54ef933861ed3b;hb=HEAD > ) > > BTW, I think the patches should be merged, once those changes that I > have mentioned are made. They are pretty straightforward. Also, a > slight description on io vectors will be awesome! (in the patch > description) > > Thanks! > Dhaval > > ------------------------------------------------------------------------------ > All of the data generated in your IT infrastructure is seriously valuable. > Why? It contains a definitive record of application performance, security > threats, fraudulent activity, and more. Splunk takes this data and makes > sense of it. IT sense. And common sense. > http://p.sf.net/sfu/splunk-d2d-c2 ------------------------------------------------------------------------------ All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2d-c2 _______________________________________________ Libcg-devel mailing list Libcg-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libcg-devel
