On Thu, Nov 10, 2011 at 11:39 PM, Vivek Goyal <vgo...@redhat.com> wrote: > On Thu, Nov 10, 2011 at 11:24:45PM +0530, Dhaval Giani wrote: >> On Thu, Nov 10, 2011 at 10:15 PM, Vivek Goyal <vgo...@redhat.com> wrote: >> > Hi, >> > >> > I had few questions about error handling in libcg. >> > >> > - Do we have error strings associated with error codes (other libraries >> > like glibc, glib2 do have). >> > >> > - What is error ECGSENTINEL. Comment says that new error codes should >> > go above it but I see error codes below it too. >> > >> >> What happened was that someone (Balbir) in commit >> bcf5c9ac11e899311ba0f3ba1b551ec62b8602cc introduced an error below >> EGSENTINEL and I missed it during the review. Now adding new errors >> above SENTINEL would break ABI so we were forced to continue below. >> >> > - Is ECGOTHER a good interface for getting to errors returned by glibc. >> > Should we remap those errors to libcg codes as relevant. I see that >> > glib2 does so at least for file errors. >> > >> >> We should for a few for sure. Do you have a list to start with? > > I don't have a list. But good to know that there is agreement on the > remapping method. If I run into any, will let you know. >
Yep, my fault IIRC. I'd be OK remapping, if a good solution works. May be for starters we just need to add a comment to the code documenting the missed intention Balbir ------------------------------------------------------------------------------ RSA(R) Conference 2012 Save $700 by Nov 18 Register now http://p.sf.net/sfu/rsa-sfdev2dev1 _______________________________________________ Libcg-devel mailing list Libcg-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libcg-devel
