I just sent comments to 6 patches other 8 are acked for me Ivana ----- Original Message ----- > From: "Peter Schiffer" <pschi...@redhat.com> > To: libcg-devel@lists.sourceforge.net > Sent: Friday, March 8, 2013 5:08:55 PM > Subject: [Libcg-devel] [PATCH v3 00/14] Logging overhaul 2 > > Hi list, > > I've found one inconsistency in enhanced logging, that cgrulesengd > has it's own > default logging level, set to WARNING. So I've added last patch, > which sets this > default level to ERROR, as in the rest of the library. > > (Checkpatch is complaining, but not because of the change in the > patch, but > because of the original code. I didn't want to break formating, so I > let it as > it is.) > > Signed-off-by: Peter Schiffer <pschi...@redhat.com> > > --- > > Peter Schiffer (14): > Removed cgroup_dbg from cgrulesengd > Reworked libcgroup logging > Enabled default logging > Reworked logging configuration > Added parsing of CGROUP_LOGLEVEL environment variable > Recognize DEBUG level of CGROUP_LOGLEVEL variable in daemon > Fixed cgrulesengd to log libcgroup log messages to syslog > Changed log level of various messages > Added new errors/warnings > Enabled logging in cgconfigparser > Added new logging to the tools > Added a test for the new logging > Added CGROUP_LOGLEVEL to man pages > Update default logging for cgrulesengd > > > configure.in | 11 -- > doc/man/cgclassify.1 | 11 +- > doc/man/cgclear.1 | 6 + > doc/man/cgconfigparser.8 | 6 + > doc/man/cgcreate.1 | 5 + > doc/man/cgdelete.1 | 6 + > doc/man/cgexec.1 | 11 +- > doc/man/cgget.1 | 6 + > doc/man/cgrulesengd.8 | 16 ++- > doc/man/cgset.1 | 6 + > doc/man/cgsnapshot.1 | 6 + > doc/man/lscgroup.1 | 8 +- > doc/man/lssubsys.1 | 7 + > include/Makefile.am | 2 > include/libcgroup.h | 1 > include/libcgroup/init.h | 4 + > include/libcgroup/log.h | 147 +++++++++++++++++++++++++++++++ > src/Makefile.am | 2 > src/api.c | 125 ++++++++++++++++---------- > src/config.c | 18 +++- > src/daemon/cgrulesengd.c | 221 > +++++++++++++++++++++++++++++++--------------- > src/libcgroup-internal.h | 11 +- > src/libcgroup.map | 5 + > src/log.c | 96 ++++++++++++++++++++ > src/tools/cgconfig.c | 2 > src/tools/tools-common.h | 9 +- > tests/Makefile.am | 7 + > tests/logger.c | 53 +++++++++++ > tests/logger.sh | 137 +++++++++++++++++++++++++++++ > 29 files changed, 784 insertions(+), 161 deletions(-) > create mode 100644 include/libcgroup/log.h > create mode 100644 src/log.c > create mode 100644 tests/logger.c > create mode 100755 tests/logger.sh > > -- > > > ------------------------------------------------------------------------------ > Symantec Endpoint Protection 12 positioned as A LEADER in The > Forrester > Wave(TM): Endpoint Security, Q1 2013 and "remains a good choice" in > the > endpoint security space. For insight on selecting the right partner > to > tackle endpoint security challenges, access the full report. > http://p.sf.net/sfu/symantec-dev2dev > _______________________________________________ > Libcg-devel mailing list > Libcg-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/libcg-devel >
------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_mar _______________________________________________ Libcg-devel mailing list Libcg-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libcg-devel
