On Thu, Aug 22, 2013 at 8:32 AM, Ivana Varekova <varek...@redhat.com> wrote: > > > ----- Original Message ----- >> From: "Weng Meiling" <wengmeiling.w...@huawei.com> >> To: libcg-devel@lists.sourceforge.net >> Cc: "libo chen" <libo.c...@huawei.com> >> Sent: Friday, August 2, 2013 10:27:00 AM >> Subject: [Libcg-devel] [PATCH]add the value check before set the control >> file value >> >> >> From: Weng Meiling <wengmeiling.w...@huawei.com> >> >> When we use memory subsystem, the memory.oom_control value we get like >> this: >> >> oom_kill_disable 0 >> under_oom 0 >> >> but we set the value just by writing a value(0 or 1) like this: >> >> #echo 1 > memory.oom_control >> >> so setting the value memory.oom_control by cgset --copy-from or >> the config from cgsnapshot will fail, so before setting the control >> file value, checking the value and resetting the value. >> >> Signed-off-by: Weng Meiling <wengmeiling.w...@huawei.com> > The solution is not optimal, but it fix the problem which you describes for > now. Thus I ack the solution. > If there will be no negative reply I will merge it on Tuesday.
I am not convinced this is the best way to solve the problem, or that we must even merge it. Yes, it is a problem, but that is just a hack. Can we do better? Dhaval ------------------------------------------------------------------------------ Introducing Performance Central, a new site from SourceForge and AppDynamics. Performance Central is your source for news, insights, analysis and resources for efficient Application Performance Management. Visit us today! http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk _______________________________________________ Libcg-devel mailing list Libcg-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libcg-devel
