----- Original Message ----- > From: "Libo Chen" <clbchenlibo.c...@huawei.com> > To: "Ivana Hutarova Varekova" <varek...@redhat.com> > Cc: "Libcg Development list" sourceforge.net>, "Li Zefan" > <lize...@huawei.com>, "Huang Qiang" > huangqi...@huawei.com>, "Wengmeiling" <wengmeiling.w...@huawei.com> > Sent: Friday, August 30, 2013 5:05:13 AM > Subject: [PATCH v2 1/5] cgcreate: add err check > > > cgroup still can be created even if giving invalid -d,-f,-s parameter > e.g. > cgcreate -g cpu:/test -d 888 > "888" is invalid, but test will be cgreated. > > So we should exit if -d,-f or -s is invalid > > Signed-off-by: Libo Chen <clbchenlibo.c...@huawei.com> > --- > src/tools/cgcreate.c | 9 ++++++--- > 1 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/src/tools/cgcreate.c b/src/tools/cgcreate.c > index b0003b1..6b80b79 100644 > --- a/src/tools/cgcreate.c > +++ b/src/tools/cgcreate.c > @@ -138,15 +138,18 @@ int main(int argc, char *argv[]) > break; > case 'd': > dirm_change = 1; > - ret = parse_mode(optarg, &dir_mode, argv[0]); > + if (parse_mode(optarg, &dir_mode, argv[0])) > + goto err; in this way return value is 0 even if this problem occurs and no cgroup is created. I prefer to set ret variable to nonzero value here (and in the next hunks). > break; > case 'f': > filem_change = 1; > - ret = parse_mode(optarg, &file_mode, argv[0]); > + if (parse_mode(optarg, &file_mode, argv[0])) > + goto err; > break; > case 's': > filem_change = 1; > - ret = parse_mode(optarg, &tasks_mode, argv[0]); > + if (parse_mode(optarg, &tasks_mode, argv[0])) > + goto err; > break; > default: > usage(1, argv[0]); > -- > 1.7.1 > >
------------------------------------------------------------------------------ Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk _______________________________________________ Libcg-devel mailing list Libcg-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libcg-devel
