Acked, I will merge the patch soon. Ivana ----- Original Message ----- > From: "Weng Meiling" <wengmeiling.w...@huawei.com> > To: libcg-devel@lists.sourceforge.net > Sent: Tuesday, September 3, 2013 4:04:48 AM > Subject: Re: [Libcg-devel] [PATCH] cgred:cgred should start when cgroup is > mounted. > > On 2013/9/3 9:23, Weng Meiling wrote: > > Hi Ivana, > > > > what do you think about this patch ? > > > > Thanks! > > Weng Meiling > > > > > sorry, please review the second version: > http://sourceforge.net/mailarchive/forum.php?thread_name=52022AB3.20509%40huawei.com&forum_name=libcg-devel > > > > On 2013/8/6 15:39, Weng Meiling wrote: > >> > >> From: Weng Meiling <wengmeiling.w...@huawei.com> > >> > >> If we mount the cgroup without the name cgroup like the following: > >> > >> #mount > >> cpu on /cgroup/cpu type cgroup (rw,cpu) > >> > >> the cgred service will start failed, because it just check the name. > >> So changing cgred to check the mounted system's type instead of the name. > >> > >> Signed-off-by: Weng Meiling <wengmeiling.w...@huawei.com> > >> --- > >> scripts/init.d/cgred.in | 2 +- > >> 1 files changed, 1 insertions(+), 1 deletions(-) > >> > >> diff --git a/scripts/init.d/cgred.in b/scripts/init.d/cgred.in > >> index ed757cf..c306fe7 100644 > >> --- a/scripts/init.d/cgred.in > >> +++ b/scripts/init.d/cgred.in > >> @@ -73,7 +73,7 @@ start() > >> log_failure_msg "$servicename is already running with PID > >> `cat > >> ${pidfile}`" > >> return 0 > >> fi > >> - if ! grep "^cgroup" /proc/mounts &>/dev/null; then > >> + if ! grep "cgroup" /proc/mounts | awk '{print $3}' &>/dev/null; > >> then > >> echo > >> log_failure_msg $"Cannot find cgroups, is cgconfig > >> service running?" > >> return 1 > >> > > > > > > ------------------------------------------------------------------------------ > Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! > Discover the easy way to master current and previous Microsoft technologies > and advance your career. Get an incredible 1,500+ hours of step-by-step > tutorial videos with LearnDevNow. Subscribe today and save! > http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk > _______________________________________________ > Libcg-devel mailing list > Libcg-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/libcg-devel >
------------------------------------------------------------------------------ Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk _______________________________________________ Libcg-devel mailing list Libcg-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libcg-devel
