On Tue, Sep 3, 2013 at 9:43 PM, Weng Meiling
<wengmeiling.w...@huawei.com> wrote:
> On 2013/9/3 20:05, Dhaval Giani wrote:
>> On Fri, Aug 2, 2013 at 4:24 AM, Weng Meiling
>> <wengmeiling.w...@huawei.com> wrote:
>>>
>>> From: Weng Meiling <wengmeiling.w...@huawei.com>
>>>
>>> When we use cgclear to unload the cgroup filesystem, we still can
>>> see the umounted cgroup by using mount command. So fix the problem
>>> by call system.
>>>
>>> From: Weng Meiling <wengmeiling.w...@huawei.com>
>>
>> NAK
>>
>> umount system call is the documented way to unmount a filesystem. I
>> would like some more investigation as to why this is happening? Can
>> you try seeing if you see this behavior with a tmpfs as well? And with
>> other filesystems? Is it something that is limited cgroupfs? Does
>> using umount2 with MNT_DETACH help after a whlie?
>>
>> Thanks!
>> Dhaval
>>
>>
> This happens only when mount cgroupfs using mount command not cgconfig
> service or cgconfigparser. Because when using mount command, it will update 
> the
> /etc/mtab file to record the mounted filesystem. When using cgclear to unload
> the cgroupfs, it uses umount2, but the syscall doesn't update the /etc/mtab to
> removed the umouted filesystem. So the patch try to using umount8 which will
> update the /etc/mtab. The same as other filesystem if they use umount2 to 
> umount
> the filesystem.

As long as /proc/mounts is correct, we don't have a problem. In
anycase, /etc/mtab is not the correct way to check mounted
filesystems. It is always /proc/mounts.

This patch is unnecessary (and dangerous)

Thanks!
Dhaval

------------------------------------------------------------------------------
Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!
Discover the easy way to master current and previous Microsoft technologies
and advance your career. Get an incredible 1,500+ hours of step-by-step
tutorial videos with LearnDevNow. Subscribe today and save!
http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk
_______________________________________________
Libcg-devel mailing list
Libcg-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libcg-devel

Reply via email to