----- Original Message ----- > From: "Ivana Varekova" <[email protected]> > To: "Libo Chen" <[email protected]> > Cc: "wengmeiling weng" <[email protected]>, [email protected], > [email protected], > [email protected] > Sent: Wednesday, September 4, 2013 10:04:46 PM > Subject: Re: [Libcg-devel] [PATCH v3 6/8] cgconfig: add parameter check > > > > ----- Original Message ----- > > From: "Libo Chen" <[email protected]> > > To: [email protected] > > Cc: "dhaval giani" <[email protected]>, [email protected], > > [email protected], > > [email protected], "h huangqiang" <[email protected]>, "wengmeiling > > weng" <[email protected]>, > > "libo chen" <[email protected]> > > Sent: Tuesday, September 3, 2013 10:49:19 AM > > Subject: [PATCH v3 6/8] cgconfig: add parameter check > > > > From: Libo Chen <[email protected]> > > > > we should check invalite parameter, and then print a warning > > > > v3: > > - usage has changed, so no need of fprintf output > > v2: > > - change print info format. This is suggested > > by Dhaval Giani <[email protected]> > > > > Signed-off-by: Libo Chen <[email protected]> because of 7/8 Acked-by: Ivana Hutarova Varekova <[email protected]> > > --- > > src/tools/cgconfig.c | 6 ++++++ > > 1 files changed, 6 insertions(+), 0 deletions(-) > > > > diff --git a/src/tools/cgconfig.c b/src/tools/cgconfig.c > > index c856a91..c4328bd 100644 > > --- a/src/tools/cgconfig.c > > +++ b/src/tools/cgconfig.c > > @@ -151,6 +151,12 @@ int main(int argc, char *argv[]) > > } > > } > > > > + if (argv[optind]) { > > + usage(1, argv[0]); > > + error = -1; > > + goto err; > > + } > > + > <- cgroup_free(&default_group); is useless here > > /* set default permissions */ > > default_group = cgroup_new_cgroup("default"); > > if (!default_group) { > > -- > > 1.7.1 > > > > > > > > ------------------------------------------------------------------------------ > Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! > Discover the easy way to master current and previous Microsoft technologies > and advance your career. Get an incredible 1,500+ hours of step-by-step > tutorial videos with LearnDevNow. Subscribe today and save! > http://pubads.g.doubleclick.net/gampad/clk?id=58041391&iu=/4140/ostg.clktrk > _______________________________________________ > Libcg-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/libcg-devel >
------------------------------------------------------------------------------ Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58041391&iu=/4140/ostg.clktrk _______________________________________________ Libcg-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/libcg-devel
