On 09/17/2013 08:49 AM, Ivana Hutarova Varekova wrote:
> This change is suggested by Dhaval Giani <dhaval.gi...@gmail.com>.
> Polish "usage function and remove a level of indentation.
>
> Signed-off-by: Ivana Hutarova Varekova <varek...@redhat.com>
> ---
>
> src/tools/cgclassify.c | 22 ++++++++++------------
> 1 files changed, 10 insertions(+), 12 deletions(-)
>
> diff --git a/src/tools/cgclassify.c b/src/tools/cgclassify.c
> index 2f80aca..bb54424 100644
> --- a/src/tools/cgclassify.c
> +++ b/src/tools/cgclassify.c
> @@ -37,19 +37,17 @@ static void usage(int status, const char *program_name)
> fprintf(stderr, "Wrong input parameters,"
> " try %s -h' for more information.\n",
> program_name);
> - } else {
> - printf("Usage: %s"\
> - "[-g <controllers>:<path>]"
> - "[--sticky | --cancel-sticky] <list of pids>\n",
> - program_name);
> - printf("Move running task(s) to given cgroups\n");
> - printf(" -g <controllers>:<path> Control group "\
> - "to be displayed (-g is optional)\n");
> - printf(" --sticky cgred daemon "\
> - "does not change pidlist and children tasks\n");
> - printf(" --cancel-sticky cgred daemon "\
> - "change pidlist and children tasks\n");
> + return;
> }
> + printf("Usage: %s [-g <controllers>:<path>] "\
> + "[--sticky | --cancel-sticky] <list of pids>\n", program_name);
> + printf("Move running task(s) to given cgroups\n");
> + printf(" -g <controllers>:<path> Control group to be displayed "\
s/displayed/used as target? ^^^
> + "(-g is optional)\n");
I would omit "-g is optional", --sticky is optional too. IMHO square
brackets are enough.
Otherwise Acked-by: Jan Safranek <jsafr...@redhat.com>
> + printf(" --sticky cgred daemon does not change "\
> + "pidlist and children tasks\n");
> + printf(" --cancel-sticky cgred daemon change pidlist "\
> + "and children tasks\n");
> }
>
> /*
>
>
> ------------------------------------------------------------------------------
> LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99!
> 1,500+ hours of tutorials including VisualStudio 2012, Windows 8, SharePoint
> 2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack includes
> Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/20/13.
> http://pubads.g.doubleclick.net/gampad/clk?id=58041151&iu=/4140/ostg.clktrk
> _______________________________________________
> Libcg-devel mailing list
> Libcg-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/libcg-devel
>
------------------------------------------------------------------------------
LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99!
1,500+ hours of tutorials including VisualStudio 2012, Windows 8, SharePoint
2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack includes
Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/20/13.
http://pubads.g.doubleclick.net/gampad/clk?id=58041151&iu=/4140/ostg.clktrk
_______________________________________________
Libcg-devel mailing list
Libcg-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libcg-devel
