On Thu, Sep 26, 2013 at 11:16 PM, Weng Meiling <wengmeiling.w...@huawei.com> wrote: > On 2013/9/27 9:17, Dhaval Giani wrote: >> Hi weng, >> >> On Thu, Sep 26, 2013 at 9:09 PM, Weng Meiling >> <wengmeiling.w...@huawei.com> wrote: >>> Hi Dhaval, >>> >>> what do you think about this patch ? >>> >> >> Sorry about this. It totally slipped my filters. >> > > It doesn't matter. > >>> Thanks! >>> Weng Meiling >>> >>> On 2013/9/10 16:12, Ivana Varekova wrote: >>>> Hello, >>>> I'm not sure about this change. >>>> >From my point of view cgconfig should work, when the file is empty (it is >>>> >equivalent to file which contains only comments). >>>> But it should return an error when the file is missing (somebody remove >>>> that file, because of it is there by default). >>>> It is only my opinion I can't find any example which deals with the >>>> similar situation. >>>> Dhaval, please what is your opinion. >> >> I agree with Ivana. It should work when the file is empty, but when it >> is missing, we should let the system know the file was not found. >> Having said that, we probably should fail for only comments/empty file >> with a different error. >> >> Thanks! >> Dhaval >> >> > Hi Dhaval, > I'm sorry, I am still a little confusing. So the final solution is the > cgconfig service should work for only comments/empty file or it should > fail with a different error? The cgconfigparser command works successfully > for comments/empty file without any errors. >
They both should be fatal, but with a different error is the ideal behavior imo. (Well, empty file/comments is fatal in the sense nothing happened, but it should still be reported to the user. might have to be under some verbose level though) Dhaval ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60133471&iu=/4140/ostg.clktrk _______________________________________________ Libcg-devel mailing list Libcg-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libcg-devel
