----- Original Message -----
> From: "Peter Schiffer" <pschi...@redhat.com>
> To: libcg-devel@lists.sourceforge.net
> Sent: Thursday, October 17, 2013 3:09:55 PM
> Subject: Re: [Libcg-devel] [PATCH 6/6] be more verbose by default
>
> On 10/17/2013 02:33 PM, Stanislav Fomichev wrote:
> > Hi Peter,
> >
> >> I have to say nack to this patch. We deliberately set logging level to
> >> CGROUP_LOG_ERROR as GROUP_LOG_WARNING might be too verbose for default
> >> option. Please use configuration option to increase logging level if
> >> needed. (-v option for cgrulesengd daemon or CGROUP_LOGLEVEL
> >> environment variable).
> >
> > I did it mainly because of the following patch which skips failed
> > variables and only prints a warning:
> > [PATCH 5/6] don't stop processing when failed to set group variable
> >
> > I want this warning to be always visible. So if this [PATCH 5/6] gets
> > accepted, we need to change warn to err in:
>
> This change below looks reasonable. For [PATCH 5/6] let's better wait
> for Ivana's opinion, whether there might be a problem.
Hello,
As I understand Stanislav wont to add this patch if and only if [PATCH 5/6]
will be incorporated.
I'd like to wait for Stanislav's reply to Dhaval question regarding [PATCH 5/6].
Ivana
> Acked-by: Peter Schiffer <pschi...@redhat.com>
> > diff --git a/src/api.c b/src/api.c
> > index 790a1588038d..b58057135116 100644
> > --- a/src/api.c
> > +++ b/src/api.c
> > @@ -1660,7 +1660,7 @@ int cgroup_create_cgroup(struct cgroup *cgroup, int
> > ignore_ownership)
> > * ignore it specifically if they wish.
> > */
> > if (error) {
> > - cgroup_warn("Warning: failed to set %s: %s
> > (%d)\n",
> > + cgroup_err("Error: failed to set %s: %s
> > (%d)\n",
> > path, cgroup_strerror(error),
> > error);
> > retval = ECGCANTSETVALUE;
> > continue;
> >
>
>
> ------------------------------------------------------------------------------
> October Webinars: Code for Performance
> Free Intel webinars can help you accelerate application performance.
> Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
> the latest Intel processors and coprocessors. See abstracts and register >
> http://pubads.g.doubleclick.net/gampad/clk?id=60135031&iu=/4140/ostg.clktrk
> _______________________________________________
> Libcg-devel mailing list
> Libcg-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/libcg-devel
>
------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.clktrk
_______________________________________________
Libcg-devel mailing list
Libcg-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libcg-devel
