On 1/28/19 2:18 PM, Dhaval Giani wrote:
On Mon, Jan 28, 2019 at 7:19 AM Tom Hromatka <tom.hroma...@oracle.com> wrote:
On 1/26/19 9:54 AM, Dhaval Giani wrote:
On Thu, Jan 24, 2019 at 4:53 AM Tom Hromatka <tom.hroma...@oracle.com> wrote:
This patchset adds cgroup v2 support to cgget and cgset.
It may also add cgroup v2 support for other commands, but
I haven't extensively tested them yet.
How have you tested the submitted code?
Dhaval
I am really glad you asked :). At the moment, I tested this
code solely by hand.
I have been having troubles running the current built-in tests
and have started to wonder if there's an opportunity to upgrade
the test framework. When I run `make check` in a VirtualBox VM
running kernel 5.0.0-rc2, it hangs on this instruction:
make[5]: Entering directory
`/home/elrey/git/upstream-libcgroup/tests/tools/cgconfigparser'
When I run `make check` on Oracle Linux kernel 4.14.35 on real hardware,
all six tests immediately fail due to "Device or resource busy."
Also, I have to admit that I'm not fond of the destructive nature
of the tests. I have seen other low-level userspace projects
incorporate the tests and code coverage directly into github. Seems
like a good opportunity.
Thoughts?
Sounds like we have a volunteer :-)
Sorry for the slow response. I was talking with in-house Oracle
experts to better understand and scope this task.
Yes, I can pick up this assignment. I will likely split it into
two major tasks:
1. Add a unit test framework and an example test or two.
Likely googletest
https://github.com/google/googletest
2. Add a functional test framework. Right now I am leaning
toward the test framework that Paul Moore is using in
libseccomp. It's easy to run, fairly easy to write tests,
integrates nicely with github and valgrind, and so on. But
I am open to other possible solutions
https://github.com/seccomp/libseccomp/
Thoughts?
Thanks.
Tom
Dhaval
_______________________________________________
Libcg-devel mailing list
Libcg-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libcg-devel
