On 9/24/19 4:19 PM, Dhaval Giani wrote:
On Tue, Sep 24, 2019 at 1:36 PM Tom Hromatka <tom.hroma...@oracle.com> wrote:
I was unable to get the legacy tests to pass in Travis CI,
so I am disabling them for the time being.

Signed-off-by: Tom Hromatka <tom.hroma...@oracle.com>
---
  tests/Makefile.am                      | 4 +++-
  tests/tools/cgclassify/Makefile.am     | 4 +++-
  tests/tools/cgconfigparser/Makefile.am | 6 ++++--
  tests/tools/multimount/Makefile.am     | 4 +++-
  4 files changed, 13 insertions(+), 5 deletions(-)

diff --git a/tests/Makefile.am b/tests/Makefile.am
index 6d748dc..7b5890c 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -24,4 +24,6 @@ logger_SOURCES=logger.c

  EXTRA_DIST = runlibcgrouptest.sh logger.sh

-TESTS = wrapper_test runlibcgrouptest.sh logger.sh
+# Tom Hromatka - I disabled these tests because they don't successfully run
+# on Travis CI
Same thing here. "We don't run libcgroup legacy tests because they
don't successfully run on Travis CI"

If we need to know who decided that, we have `git blame` and `git log`

Good catches.  I must have forgot my coffee on the day I wrote
this patch.

I'll make the changes and send a v2 tomorrow.

Thanks.

Tom

+#TESTS = wrapper_test runlibcgrouptest.sh logger.sh
diff --git a/tests/tools/cgclassify/Makefile.am 
b/tests/tools/cgclassify/Makefile.am
index c504e7f..b24e54f 100644
--- a/tests/tools/cgclassify/Makefile.am
+++ b/tests/tools/cgclassify/Makefile.am
@@ -1,3 +1,5 @@
  EXTRA_DIST = cgclassify cgclassify-rules simple.conf

-TESTS = cgclassify cgclassify-rules
+# Tom Hromatka - I disabled these tests because they don't successfully run
+# on Travis CI
ditto

+#TESTS = cgclassify cgclassify-rules
diff --git a/tests/tools/cgconfigparser/Makefile.am 
b/tests/tools/cgconfigparser/Makefile.am
index 27a08f9..4a4acde 100644
--- a/tests/tools/cgconfigparser/Makefile.am
+++ b/tests/tools/cgconfigparser/Makefile.am
@@ -23,6 +23,8 @@ EXTRA_DIST = cgconfigparser_simple \
              cgclear/cgclear_config_multi_3.conf \
              cgclear/cgclear_config_one.conf

-TESTS = cgconfigparser_simple cgconfigparser_conf_files_tests permissions \
-       cgconfigparser_multiconfig cgclear_config_multi cgclear_config_one
+# Tom Hromatka - I disabled these tests because they don't successfully run
+# on Travis CI
+#TESTS = cgconfigparser_simple cgconfigparser_conf_files_tests permissions \
+#      cgconfigparser_multiconfig cgclear_config_multi cgclear_config_one

diff --git a/tests/tools/multimount/Makefile.am 
b/tests/tools/multimount/Makefile.am
index 8463bae..b2d316a 100644
--- a/tests/tools/multimount/Makefile.am
+++ b/tests/tools/multimount/Makefile.am
@@ -1,3 +1,5 @@
  EXTRA_DIST = many_mp many_named

-TESTS = many_mp  many_named
+# Tom Hromatka - I disabled these tests because they don't successfully run
+# on Travis CI
ditto

+#TESTS = many_mp  many_named
--
2.21.0



_______________________________________________
Libcg-devel mailing list
Libcg-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libcg-devel



_______________________________________________
Libcg-devel mailing list
Libcg-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libcg-devel

Reply via email to