[ 
https://issues.apache.org/jira/browse/LIBCLOUD-18?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860347#action_12860347
 ] 

Jeremy Orem commented on LIBCLOUD-18:
-------------------------------------

The patch looks good, but a couple of issues need addressed:

* ASF Granted License needs to be "Yes" on your file attachments
* Convert tabs to 4 spaces
* resize_node isn't part of the api right now, so it'd be best to remove it or 
make it private until a standardized extension format is agreed upon.
* list_sizes: could hardcode some sizes.  See the ec2 driver for an example.
* create_node
** should change kwargs['type'] to kwargs['image']
** Maybe this could also accept a size and call the _resize_node method after 
creating
* I wasn't able to locate dreamhost_ps-list_images in the docs.  Does this 
method still exist?

> New Libcloud Driver for DreamHost Private Servers
> -------------------------------------------------
>
>                 Key: LIBCLOUD-18
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-18
>             Project: Libcloud
>          Issue Type: New Feature
>          Components: Core
>            Reporter: Kyle Marsh
>            Assignee: Jeremy Orem
>            Priority: Minor
>         Attachments: dreamhost_driver.patch, dreamhost_driver_squash.patch
>
>   Original Estimate: 3h
>  Remaining Estimate: 3h
>
> Driver to expose the DreamHost Private Server API through Libcloud.
> It currently implements all of the Libcloud interface except list_sizes and 
> list_locations which don't have any meaningful equivalents with DreamHost's 
> private servers.  There are elements of the DreamHost API that are not 
> currently exposed by this driver that may be exposed in the future.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to