Re: [libcloud] GoGrid driver regression?

[Roman Bogorodskiy]

Hello,

Looks like the regression was committed again:

http://github.com/apache/libcloud/commit/18760441a53f4d8267d48f6ca7e6ca74e421b230

I've updated fixture and tests to catch this regression, patch attached
and also uploaded here:

http://people.freebsd.org/~novel/patches/non-freebsd/gogrid_id.diff

Roman Bogorodskiy

diff --git a/libcloud/drivers/gogrid.py b/libcloud/drivers/gogrid.py
index 4126f65..dc08fc2 100644
--- a/libcloud/drivers/gogrid.py
+++ b/libcloud/drivers/gogrid.py
@@ -150,8 +150,6 @@ class GoGridNodeDriver(NodeDriver):
         state = self._get_state(element)
         ip = self._get_ip(element)
         id = self._get_id(element)
-        if id == None:
-          raise Exception("ID is missing from Node response: "+ element)
         n = GoGridNode(id=id,
                  name=element['name'],
                  state=state,
diff --git a/test/fixtures/gogrid/server_add.json b/test/fixtures/gogrid/server_add.json
index 56271ef..35a4ca1 100644
--- a/test/fixtures/gogrid/server_add.json
+++ b/test/fixtures/gogrid/server_add.json
@@ -1,7 +1,6 @@
 {
     "list": [
         {
-            "id": 90967,
             "image": {
                 "billingtokens": [
                     {
diff --git a/test/test_gogrid.py b/test/test_gogrid.py
index 47df2e0..17ad667 100644
--- a/test/test_gogrid.py
+++ b/test/test_gogrid.py
@@ -38,8 +38,8 @@ class GoGridTests(unittest.TestCase, TestCaseMixin):
         image = NodeImage(1531, None, self.driver)
         size = NodeSize('512Mb', None, None, None, None, None, driver=self.driver)
 
-        node = self.driver.create_node(name='foo', image=image, size=size)
-        self.assertEqual(node.id, 90967)
+        node = self.driver.create_node(name='test1', image=image, size=size)
+        self.assertEqual(node.name, 'test1')
 
     def test_list_nodes(self):
         node = self.driver.list_nodes()[0]