[
https://issues.apache.org/jira/browse/LIBCLOUD-41?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12883223#action_12883223
]
Steve Steiner commented on LIBCLOUD-41:
---------------------------------------
In my opinion, having required "extra" parameters without sensible defaults
kind of defeats the purpose of libcloud.
The intention expressed in the original code would have sensibly defaulted this
and someone who needed finer grained control could have passed the parameter as
needed, when needed.
S
> Linode driver throws exception if "location" keyword argument not supplied
> even though comments indicate otherwise
> ------------------------------------------------------------------------------------------------------------------
>
> Key: LIBCLOUD-41
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-41
> Project: Libcloud
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.3.0
> Environment: Any
> Reporter: Steve Steiner
> Fix For: 0.3.0
>
>
> Linode driver throws exception if "location" keyword argument not supplied to
> node_create() even though comments indicate otherwise. All of the other
> keyword arguments are also not defaulted which does not match the base.py
> create_node documentation.
> The comments in drivers/linode.py say:
> # As Linode requires choosing a datacenter, a little logic is done.
> and then go onto describe a process for automatically choosing a datacenter
> and/or calling linode_set_datacenter.
> Unfortunately, the "location" keyword still has to be passed in or the
> function fails since line 239 directly references the parameter (and all the
> others as well) without the traditional default handling for non-required
> keyword arguments.
> Presumably, the default should be properly handled by coding the "little
> logic" in place of the comments about it...
> Alternatively, handling the linode_set_datacenter setting of self.datacenter
> could be used to provide a sensible default.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
