Hello, On 04/27/2013 08:55 PM, markus.hoeni...@mhoenicka.de wrote: > Peter Czanik writes: > > Hello, > > I don't know if it's a problem in libdbi-drivers code or in openSUSE > > Build Service code checking scripts (I can't code in C, just > > package...), but right now I can't package libdbi-drivers as I get the > > following warnings and error: > > > > [ 11s] I: Program is using implicit definitions of functions getting > > [ 11s] pointers or implemented by macros. These functions need to > > use their > > [ 11s] correct prototypes to allow correct argument passing on e.g. > > x86_64 . > > [ 11s] - Implicit memory/string functions need #include <string.h>. > > [ 11s] - Implicit *printf functions need #include <stdio.h>. > > [ 11s] - Implicit *printf functions need #include <stdio.h>. > > [ 11s] - Implicit *read* functions need #include <unistd.h>. > > [ 11s] - Implicit *recv* functions need #include <sys/socket.h>. > > [ 11s] W: libdbi-drivers implicit-pointer-decl src/unit.c:229 > > [ 11s] E: libdbi-drivers 64bit-portability-issue src/constraint.c:167, > 168 > > > > The full log is available at > > > https://build.opensuse.org/package/rawlog?arch=x86_64&package=libdbi-drivers&project=home%3Aczanik%3Alibdbi&repository=openSUSE_Factory > > Could you take a look at it? > > Hi, > > the offending code appears to be in the copy of cgreen which we ship > as a test harness along with the libdbi-drivers sources. I don't fully > understand what the code checking scripts complain about but > apparently some of the prototypes in the include files rely on global > include files which are only included *after* the local include > files. The appended patches revert the order of includes. Could you > please check if that helps? No, they did not seem to fix the problem. You can see the exact compile messages at https://build.opensuse.org/package/rawlog?arch=i586&package=libdbi-drivers&project=home%3Aczanik%3Alibdbi&repository=openSUSE_Factory The offending lines seem to be:
[ 28s] gcc -DHAVE_CONFIG_H -I. -I../.. -Iinclude -fomit-frame-pointer -fmessage-length=0 -grecord-gcc-switches -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables -fasynchronous-unwind-tables -std=gnu99 -fomit-frame-pointer -fmessage-length=0 -grecord-gcc-switches -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables -fasynchronous-unwind-tables -c -o text_reporter.o `test -f 'src/text_reporter.c' || echo './'`src/text_reporter.c [ 28s] src/constraint.c: In function 'with_': [ 28s] src/constraint.c:104:22: warning: assignment from incompatible pointer type [enabled by default] [ 28s] src/constraint.c: In function 'compare_using_matcher': [ 28s] src/constraint.c:167:32: warning: initialization makes pointer from integer without a cast [enabled by default] [ 28s] src/constraint.c:168:5: warning: passing argument 1 of 'matches' makes pointer from integer without a cast [enabled by default] [ 28s] src/constraint.c:168:5: note: expected 'const void *' but argument is of type 'intptr_t' BTW: Is it really necessary to compile this code? Seems to be something testing related and I don't run 'make check' during package building... Bye, -- Peter Czanik (CzP) <cza...@balabit.hu> BalaBit IT Security / syslog-ng upstream http://czanik.blogs.balabit.com/ ------------------------------------------------------------------------------ Try New Relic Now & We'll Send You this Cool Shirt New Relic is the only SaaS-based application performance monitoring service that delivers powerful full stack analytics. Optimize and monitor your browser, app, & servers with just a few lines of code. Try New Relic and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr _______________________________________________ libdbi-devel mailing list libdbi-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libdbi-devel
