Hi, thanks for contributing this patch. I've applied it to the current cvs version with minor hassles. The success of this patch as judged by running valgrind on the test suite is as follows:
before: ==1252== LEAK SUMMARY: ==1252== definitely lost: 618 bytes in 16 blocks. ==1252== possibly lost: 16 bytes in 2 blocks. ==1252== still reachable: 8441 bytes in 13 blocks. ==1252== suppressed: 0 bytes in 0 blocks. after: ==1624== LEAK SUMMARY: ==1624== definitely lost: 314 bytes in 12 blocks. ==1624== possibly lost: 0 bytes in 0 blocks. ==1624== still reachable: 8320 bytes in 3 blocks. ==1624== suppressed: 0 bytes in 0 blocks. A clear improvement! I'll apply the same patch to the sqlite driver whose internals are almost identical. regards, Markus Phil Longstaff writes: > I've attached a patch which fixes some memory leaks in the sqlite3 driver. > In general, there were 3 kinds of leaks: > > 1) dbd_query results which were not freed > 2) sqlite3_get_table tables which were not freed > 3) asprintf results which were not freed. > > This is based on libdbi-drivers-0.8.2-1. > -- Markus Hoenicka [EMAIL PROTECTED] (Spam-protected email: replace the quadrupeds with "mhoenicka") http://www.mhoenicka.de ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php _______________________________________________ Libdbi-drivers-devel mailing list Libdbi-drivers-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libdbi-drivers-devel
