On Wed, 2008-08-06 at 10:04 +0200, Markus Hoenicka wrote: > Quoting Balazs Scheidler <[EMAIL PROTECTED]>: > > > It works with light testing, e.g. now it does not crash where it used > > to. I did not check for leaks or similar stuff, however I think I only > > needed to free the allocated memory in dbd_disconnect() and in case of > > an error. I've added both of these spots, so it should be ok in this > > regard. We are installing the patch in production, but now I think it is > > safe to commit it. > > > > So I assume that "make check" runs without errors and without > crashing? It is probably a good idea to add a check to test_dbi.c for > creating two connections at a time too. I'll look into this.
Well, no, I didn't run make check. We ran the testcase of our customer's scenario which triggered a crash. > > > > > Just let me know if you accept patches that remove these kind of code > > blocks. (for instance the oracle compilation problem we fixed last > > contained some dead code that I didn't remove, as I didn't want to be > > too intrusive. if it was my code, I would have removed those as well). > > As far as I know no one currently claims to be "the" oracle > maintainer, so chances are low that you will step on anyone's toes. > Feel free to go ahead and remove the dead code. ok. > > > > > Another completely unrelated topic: have you thought of using git > > instead of CVS? It would be so much simpler to contribute :) > > > > I'm not familiar with git, and I felt perfectly fine so far using the > infrastructure provided by SourceForge. I have other SF projects using > Subversion which I personally prefer to CVS, but I avoided the > migration hassles for libdbi and libdbi-drivers. > > All you need to do to check in your patches is to get a SF account > (which you may already have) and to allow me to add you as a developer > to libdbi-drivers. I didn't have an sf.net account, but I've just registered one. My username is bazsi77, email: [EMAIL PROTECTED] How should I commit patches? Post it here for review and once I get an ACK, go ahead and commit it? -- Bazsi ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Libdbi-drivers-devel mailing list Libdbi-drivers-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libdbi-drivers-devel
