Jan Engelhardt writes:
>
> The find_result_field_types function in dbd_sqlite3.c
> tests for total( abs( and round( twice, which seems redundant.
>
> if ( strstr(curr_field_lower,"avg(") ||
> strstr(curr_field_lower,"sum(") ||
> strstr(curr_field_lower,"total(") ||
> strstr(curr_field_lower,"abs(") ||
> strstr(curr_field_lower,"round(") ) {
> return FIELD_TYPE_FLOAT;
> }
> ...
> if ( strstr(curr_field_lower,"randomblob(") ||
> strstr(curr_field_lower,"zeroblob(") ||
> strstr(curr_field_lower,"total(") ||
> strstr(curr_field_lower,"abs(") ||
> strstr(curr_field_lower,"round(") ) {
> return FIELD_TYPE_BLOB;
> }
Hi,
the second occurrences of these checks were indeed never reached
during execution. I've checked in a fix (revision 1.51).
thanks
Markus
--
Markus Hoenicka
http://www.mhoenicka.de
AQ score 38
------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk
_______________________________________________
Libdbi-drivers-devel mailing list
Libdbi-drivers-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libdbi-drivers-devel
