Prach Pongpanich writes: > Hi Markus, > > On Tue, Jan 28, 2014 at 6:27 PM, Markus Hoenicka > <markus.hoeni...@mhoenicka.de> wrote: > > At 2014-01-27 06:33 Prach Pongpanich was heard to say: > > > >> Hi, > >> > >> > >> I've got some tests failures(test_dbi_result_get_as_longlong) on arch > >> below. > >> > >> armel, armhf, mips, mipsel, powerpc and sparc > >> > >> Full build logs: > >> https://buildd.debian.org/status/package.php?p=libdbi-drivers > >> > > thank you for the heads-up. I had noticed these test failures in previous > > mails from the Debian system but didn't get round to take care of them. I > > have a hunch that the atoll() call which the sqlite3 driver uses to convert > > raw data into a long long number causes problems - at least the code line > > carries a comment suggesting that it may cause problems. I'll see what I > > can > > do. > > > > As GNU libc manual[1] on parsing integers states: > Function: long long int atoll (const char *string) > "This function is similar to atol, except it returns a long long int. > The atoll function was introduced in ISO C99. It too is obsolete > (despite having just been added); use strtoll instead." > > [1] > http://www.gnu.org/software/libc/manual/html_node/Parsing-of-Integers.html > > Regards, > Prach >
Hi, I've attached a patch that changes the atoll() call to strtoll(). Works fine on FreeBSD. This is basically a one-line patch, although I'll remove the atoll() checks from configure if the patch indeed cures the problem. Can you feed this patch into your builds, or do you need a complete tarball? regards, Markus
dbd_sqlite3.c.diff
Description: Binary data
-- Markus Hoenicka http://www.mhoenicka.de AQ score 38
------------------------------------------------------------------------------ WatchGuard Dimension instantly turns raw network data into actionable security intelligence. It gives you real-time visual feedback on key security issues and trends. Skip the complicated setup - simply import a virtual appliance and go from zero to informed in seconds. http://pubads.g.doubleclick.net/gampad/clk?id=123612991&iu=/4140/ostg.clktrk
_______________________________________________ Libdbi-drivers-devel mailing list Libdbi-drivers-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libdbi-drivers-devel
