Mike Rylander writes:
> I'd be interested to see what the optimization was. :)
>
I've replaced
if (strlen(*cur)) {
with
if (*cur) {
Saves us one function call. Whoohoo.
Besides, I've changed index() calls to strchr() calls just to make
the code consistent.
> > 04:05:06-08:00 (time)
> > 1999-01-08 04:05:06 -8:00 (timestamp)
>
> It may just be a typo, but this is incorrect based on my original
> patch. I followed ISO8601 format for using numeric timezone
> extentions on a timestamp, which requires the format of
>
> {+|-}hh[:mm]
>
According to my tests both '-8:00' and '-08:00' work. '-0800' is
another option, whereas '-800' fails (correctly so). I did not change
the logic of your string parsing. Your patch is probably a bit more
forgiving than you thought. In any case, according to the PostgreSQL
docs all of the above notations that work conform to ISO8601.
regards,
Markus
--
Markus Hoenicka
[EMAIL PROTECTED]
(Spam-protected email: replace the quadrupeds with "mhoenicka")
http://www.mhoenicka.de
-------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
libdbi-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/libdbi-users
