2008/6/2, Nick Mathewson <[EMAIL PROTECTED]>: > > On Sun, Jun 01, 2008 at 01:51:53PM +0800, liusifan wrote: > [...] > > This seems pretty promising, and could wind up being a better > short-term idea than our older plan to get IOCP support by making it a > new backend for bufferevents. > > How well tested is this? Can you get the unit tests to pass, at > least, to the extent that the unit tests in 1.4.4 currently pass on > win32? I'd like people who use libevent on windows to try this code > out; if it works well, we should integrate it.
Do you mean the uni tests in libevent/test directory ? I will try to get these unit tests to pass. > (For future reference, please use unified diffs (generated with diff -u) > rather than old-style diffs. They're shorter and (usually) easier > to read. This diff is small enough that there's not much worry > about this one, though.) OK, will use -u option. > add file : libevent-1.4.4-iocp\WIN32-Code\win32iocp.cpp > ^^^^ You mean ".c"? Yes. Just a type mistake. It's win32iocp.c . Hm. This might be better applied against trunk (which will eventually > become libevent 2.0) than against 1.4.4; the 1.4 series is supposed to > be stable, and Big New Features are usually out there... > > ...but now that I look at the code, it looks like the only big change > is to add a new backend file, which (as far as I can tell) doesn't > require any big changes elsewhere in the code. I'd be curious to see > what Niels thinks here, but I wouldn't be opposed to checking it into > the stable branch. These some thing i need to explain here. This patch requires to add a EV_ACCEPT macro to indicate the accept event. This is incompatible with the old code. The old code use EV_READ to indicate the accept event. Best Regards, Stephen Liu
_______________________________________________ Libevent-users mailing list Libevent-users@monkey.org http://monkeymail.org/mailman/listinfo/libevent-users
