On Tue, 2009-04-28 at 15:09 -0400, Nick Mathewson wrote: > On Sat, Apr 25, 2009 at 12:08:02PM -0700, hop...@omnifarious.org wrote: > > # HG changeset patch > > # User Eric Hopper <hop...@omnifarious.org> > > # Date 1240605517 25200 > > # Node ID 97768cd771be8ea7a4db8bd46998030dcd8c6650 > > # Parent 07c00814a3436ebd1d8628fa8c3c1d921523d1e5 > > Properly detect sense of should_check_environment and fix regression. > > > Checked in, along with unit test to catch this if it happens again. > > (When possible, if you're writing a bugfix, a unit test to make sure > it doesn't recur would be great. For new features, a unit test is > highly recommended.)
I didn't think to do that because the reason I fixed the bug is that the regression test suite was failing. :-) It wasn't failing for reasons that clearly pointed to the problem though, so a new test would definitely have been in order. Thanks, -- A word is nothing more or less than the series of historical connotations given to it. That's HOW we derive meaning, and to claim that there is an arbitrary meaning of words above and beyond the way people use them is a blatant misunderstanding of the nature of language. -- Anonymous blogger -- Eric Hopper (hop...@omnifarious.org http://www.omnifarious.org/~hopper)--
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Libevent-users mailing list Libevent-users@monkey.org http://monkeymail.org/mailman/listinfo/libevent-users
