On Thu, May 28, 2009 at 2:34 PM, James Mansion <ja...@mansionfamily.plus.com> wrote: > The issues I'd like to address are: > - bale out with sys.exit(1) is inappropriate except from main after > catching an exception > - there is no way to direct the generated files to a directory other > than the original source directory
Sounds fine to fix those issues. Please, feel free to send a patch. > I'm slightly concerned about this code - it seems to me that the code > in Generate that deals with header files and implementation files > should be in the factory - its not appropriate in a PythonCodeGenerator > or JavaCodeGenerator for example. I think the factory should be > passed argv too (or asked what options it would like to process) > but that's a bigger task and I don't propose to attack that at the > moment. The rpcgen code would greatly benefit from a complete rewrite and refactoring. That would be a fair amount of work though and I don't have the time at the moment. If you have the time, please take a stab :-) Thank you, Niels. _______________________________________________ Libevent-users mailing list Libevent-users@monkey.org http://monkeymail.org/mailman/listinfo/libevent-users
