On Tue, Mar 8, 2011 at 3:39 AM, Christophe Fillot <[email protected]> wrote: > > Nick Mathewson wrote: > > Hi Nick, >> >> When I apply this patch, the unit tests don't pass any more. I get: >> >> rpc/basic_test: [forking] OK >> rpc/basic_message: [forking] OK >> rpc/basic_client: [forking] [err] evrpc.c:109: Assertion r == 0 failed >> in evrpc_free >> [Lost connection!] >> [basic_client FAILED] >> rpc/basic_queued_client: [forking] OK >> rpc/basic_client_with_pause: [forking] [err] evrpc.c:109: Assertion r >> == 0 failed in evrpc_free >> [Lost connection!] >> [basic_client_with_pause FAILED] >> >> Did the tests pass for you? >> > Hmmm ok I'm stupid, evrpc_unregister_rpc() returns 0 for success > and -1 for error, whereas evrpc_remove_hook() returns 1 for success > and 0 for error. So I incorrectly modified the asserts for the hooks. > > The attached patch should be ok :)
Indeed, this one looks better. Merging it. Thanks! -- Nick *********************************************************************** To unsubscribe, send an e-mail to [email protected] with unsubscribe libevent-users in the body.
