Hi, Here are a few cases where error checking is missing. Not knowing the code, I can mostly just point to the issues without suggesting fixes.
- evthread_set_condition_callbacks - The first half of the function assumes cbs might be NULL. The second half references cbs without validation - evbuffer_overlapped_new - mm_calloc return value is not checked - event_base_free - All the code that follows the call to EVUTIL_ASSERT assumes that base is non NULL. Assertion are useful for a debug environment, but IMHO are not a valid tool for production code, especially in an external-facing function - A similar approach exists in GET_IO_SLOT_AND_CTOR; _ent is allocated and the assertion is supposed to cover the case of a failure. Gilad *********************************************************************** To unsubscribe, send an e-mail to majord...@freehaven.net with unsubscribe libevent-users in the body.
