On Tue, Apr 10, 2012 at 6:38 PM, Myk Taylor <myk...@yahoo.com> wrote: > On 03/26/12 01:17, Myk Taylor wrote: >> >> Alright, now that I understand a little more about how to do this, let >> me try this again : ) > > > The updated patches are now attached to the sourceforge Patches tracker: > > https://sourceforge.net/tracker/?func=detail&aid=3516647&group_id=50884&atid=461324 > > Thanks!
(crossposting there) Thanks, Myk! My first questions and reactions are: * Does this really belong on 2.0 or not? From your description of the changes, it doesn't seem like a bugfix to me; it sounds much more like a new feature. I'm open to argument, though. (Mark, why did you think this was a bugfix?) * Is it possible to write a test for this? * Probably, bev_factory_cb should have a name starting with evhttp_, since it's evhttp-specific thing. It should probably take the evhttp_connection and maybe the event_base too? I'm also hoping to hear what Mark Ellzey thinks of the interface; since I see his libevhtp as the eventual successor to evhttp, I'd like his opinion on new evhttp APIs. yrs, -- Nick *********************************************************************** To unsubscribe, send an e-mail to majord...@freehaven.net with unsubscribe libevent-users in the body.
