Hi Uwe, You wrote on Fri, Jul 31, 2020 at 11:00:50AM +0200: > when compiling ftdi.c in the context of blackmagic debug, more enabled > warnings and -Werror made me to add appended fixes. > > Fixing the signedness of baudrate would probably be more logically by > making all baudrate and clk unsigned, but would need more code > change. I decides to make clk signed as a fix with minimal > impact. The FTDI chips are far away from 2 GHz clock rate...
patch looking good, applied. Thanks! While running the baudrate code unit tests I found out the tests no longer compile when FTDIPP is disabled, so I fixed that on the go, too. Cheers, Thomas -- libftdi - see http://www.intra2net.com/en/developer/libftdi for details. To unsubscribe send a mail to [email protected]
