2012/8/27 Daniel Macks <dma...@netspace.org>: > Now that configure.ac puts -Wall in CFLAGS for the whole build process > conditional on GCC, that same flag should not also be hardcoded in any > specific makefiles. There are several instances of it in > test/automatic/Makefile.am and test/manual/Makefile.am > > While working on that, I checked the automake documentation for CFLAGS, and I > think test/automatic/Makefile.am has another problem as well. Defining that > variable there overwrites CFLAGS that the user might set earlier (propagated > from ./configure). AM_CFLAGS is the automake variable that the package-author > controls instead: > > -CFLAGS = -Wall -ggdb -DGG_IGNORE_DEPRECATED > +AM_CFLAGS = -ggdb -DGG_IGNORE_DEPRECATED > > message2 has its own _CFLAGS variable that overrides the more general AM_ > one, so they need to be merged for that case: > > -message2_CFLAGS = @LIBXML2_CFLAGS@ > +message2_CFLAGS = @LIBXML2_CFLAGS@ $(AM_CFLAGS) > > dan
That particular issue with CFLAGS in test/automatic/Makefile.am is fixed in current svn trunk for some time already. The checkout url is http://toxygen.net/svn/libgadu/trunk if you want to have a look at this. I'm not saying the fixes are like super-correct or examples of good automake practices (they're not and I'll probably fix them sometime soon) but at least they work. Thanks, Bartosz _______________________________________________ libgadu-devel mailing list libgadu-devel@lists.ziew.org http://lists.ziew.org/mailman/listinfo/libgadu-devel
