On Wednesday 12 March 2014 14:26:07 Richard W.M. Jones wrote: > This set of patches: > > - Adds new APIs to support discard in libguestfs. > > - Adds discard support to virt-format. > > - Adds discard support to virt-sysprep. > > - Implements virt-sparsify --in-place. > > This is now working, after fixing the rather stupid bug in fstrim. > > I've pushed the ones which were ACKed previously + the fstrim fix.
Sounds good, just a couple of trivial questions/notes: - blkdiscard and blkdiscardzeroes look quite similar although one is an operation and the other is a "query", would it be possible to give them clearer names? Or it is better to have them more close to what they actually do? - is there any way to check at runtime for the availability of those two functions in the kernel/fs, and maybe advertise that as "feature" (guestfs_available, etc)? -- Pino Toscano _______________________________________________ Libguestfs mailing list [email protected] https://www.redhat.com/mailman/listinfo/libguestfs
