On Wed, Jan 28, 2015 at 05:15:06PM +0100, Pino Toscano wrote: > This looks to me that it would go through all the LVs, even RW ones, > when is_read_only_lv is invoked, right? > > Considering that we get a list of all the LVs anyway when doing: > > > + let is_read_only_lv = is_read_only_lv g in > > wouldn't it be better to just get the list of UUIDs of RO LVs, and > looking for 'fs' in that? Considering that in most of the cases LVs > are RW, the list with RO LVs should be small if not empty, and thus > save checks.
Yup, makes sense. I'll rework the patch. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported. http://fedoraproject.org/wiki/MinGW _______________________________________________ Libguestfs mailing list [email protected] https://www.redhat.com/mailman/listinfo/libguestfs
