On Thu, Mar 12, 2015 at 09:02:06AM +0000, Chen, Hanxiao wrote: > > > > -----Original Message----- > > From: Richard W.M. Jones [mailto:[email protected]] > > Sent: Thursday, March 12, 2015 4:32 PM > > To: Chen, Hanxiao/陈 晗霄 > > Cc: [email protected] > > Subject: Re: [Libguestfs] [PATCH] maint.mk: remove error_message_period > > check > > > > On Wed, Mar 11, 2015 at 01:18:45AM -0400, Chen Hanxiao wrote: > > > As discussed at: > > > https://www.redhat.com/archives/libguestfs/2014-September/msg00215.html > > > > > > Signed-off-by: Chen Hanxiao <[email protected]> > > > --- > > > maint.mk | 7 ------- > > > 1 file changed, 7 deletions(-) > > > > > > diff --git a/maint.mk b/maint.mk > > > index b6ec1b5..76759d4 100644 > > > --- a/maint.mk > > > +++ b/maint.mk > > > @@ -408,13 +408,6 @@ sc_error_message_uppercase: > > > { echo '$(ME): found capitalized error message' 1>&2; \ > > > exit 1; } || : > > > > > > -# Error messages should not end with a period > > > -sc_error_message_period: > > > - @grep -nEA2 '[^rp]error *\(' $$($(VC_LIST_EXCEPT)) \ > > > - | grep -E '[^."]\."' && \ > > > - { echo '$(ME): found error message ending in period' 1>&2; \ > > > - exit 1; } || : > > > - > > > sc_file_system: > > > @prohibit=file''system \ > > > ignore_case=1 \ > > > -- > > > 2.1.0 > > > > It seems as if maint.mk is generated, although I have no idea where ... > > > > Looks like gnulib did this. > > Or we changed our error messages as gnulib's suggestion?
It looks as if cfg.mk generates maint.mk. My preference is to get rid of 'make syntax-check' entirely. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into KVM guests. http://libguestfs.org/virt-v2v _______________________________________________ Libguestfs mailing list [email protected] https://www.redhat.com/mailman/listinfo/libguestfs
