On Fri, May 15, 2015 at 03:42:20PM +0200, Pino Toscano wrote: > On Friday 15 May 2015 11:40:56 Richard W.M. Jones wrote: > > The common error function already prints the program name, so > > we don't need to print it twice. > > > > Before: > > > > $ virt-resize --expand "" > > virt-resize: error: virt-resize: empty --expand option > > > > After: > > > > $ virt-resize --expand "" > > virt-resize: error: empty --expand option > > --- > > resize/resize.ml | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/resize/resize.ml b/resize/resize.ml > > index 40a777c..33abaab 100644 > > --- a/resize/resize.ml > > +++ b/resize/resize.ml > > @@ -170,7 +170,7 @@ let main () = > > let dryrun = ref false in > > let expand = ref "" in > > let set_expand s = > > - if s = "" then error (f_"%s: empty --expand option") prog > > + if s = "" then error (f_"empty --expand option") > > else if !expand <> "" then error (f_"--expand option given twice") > > else expand := s > > in > > LGTM. > > I see few cases like that in builder/cmdline.ml, would it be possible > to add them to this patch as well?
I'll send a separate patch in a minute. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linux and Windows. http://people.redhat.com/~rjones/virt-df/ _______________________________________________ Libguestfs mailing list [email protected] https://www.redhat.com/mailman/listinfo/libguestfs
