On Mon, Oct 05, 2015 at 03:40:02PM +0300, Roman Kagan wrote: > Without rhev-apt.exe the code path where firstboot scripts are created > isn't taken, so it isn't tested and v2v/test-v2v-windows-conversion.sh > is supposed to fail (it actually doesn't but for another reason, > addressed in a followup patch). > > Signed-off-by: Roman Kagan <[email protected]> > --- > tests/fake-virt-tools/rhev-apt.exe | 1 + > 1 file changed, 1 insertion(+) > create mode 100644 tests/fake-virt-tools/rhev-apt.exe > > diff --git a/tests/fake-virt-tools/rhev-apt.exe > b/tests/fake-virt-tools/rhev-apt.exe > new file mode 100644 > index 0000000..2f472e5 > --- /dev/null > +++ b/tests/fake-virt-tools/rhev-apt.exe > @@ -0,0 +1 @@ > +This is a fake rhev-apt.exe, used for testing only > -- > 2.4.3
As with my comment on patch 1, I think it's better to put this under the v2v/ subdirectory, and you'll need to add the file to EXTRA_DIST too. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported. http://fedoraproject.org/wiki/MinGW _______________________________________________ Libguestfs mailing list [email protected] https://www.redhat.com/mailman/listinfo/libguestfs
