On 4 November 2015 at 13:07, Richard W.M. Jones <[email protected]> wrote: [...]
> > Happy to. However, these same header files have been removed in > > 3b17152ec399acb35b23331d2c3b4f424a68824a: > > > > commit 3b17152ec399acb35b23331d2c3b4f424a68824a > > Author: Richard W.M. Jones <[email protected]> > > Date: Tue Sep 29 21:58:41 2015 +0100 > > > > lib: Remove unused header files. > > > > I used ESR's deheader program to look for unused includes. I then > > examined each instance by hand, and also test-compiled (on Linux). > > > > ...which makes me suspect it will happen again at some point unless there > > is some indication that it's a non-Linux include. > > Yup, sorry about that one. > > Perhaps a comment, like: > > #include <sys/un.h> /* Required for Mac OS X */ > > ? You're the boss(es) -- I'll go with any solution that a) keeps the headers in, b) satisfies your requirements. If a comment is enough to preserve these includes during the next header purge, I'm happy to commit a new patch. -- Margaret
_______________________________________________ Libguestfs mailing list [email protected] https://www.redhat.com/mailman/listinfo/libguestfs
