On Wed, Mar 23, 2016 at 12:59:51PM +0000, Richard W.M. Jones wrote: > On Wed, Mar 23, 2016 at 10:39:43AM +0100, Pino Toscano wrote: > > If I read this correctly, the newly added memmem would be executed for > > every read data from the daemon socket: > > read_data -> handle_log_message -> memmem > > I think only from the console socket (not the daemon socket, and hence > not download APIs). However I will see if it's possible to limit this > to the accept phase anyway, since that seems like a good idea.
Not easily ... It turns out that we accept the daemon connection very early on, just after qemu starts up. (This surprised me, but makes sense given that virtio-serial is connectionless). Do you agree that this won't affect downloads and other data paths from libguestfs? Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linux and Windows. http://people.redhat.com/~rjones/virt-df/ _______________________________________________ Libguestfs mailing list [email protected] https://www.redhat.com/mailman/listinfo/libguestfs
