On Thu, Mar 24, 2016 at 03:44:40PM +0300, Roman Kagan wrote: > On Thu, Mar 24, 2016 at 11:36:13AM +0000, Richard W.M. Jones wrote: > > So it's ready to go, just swap patch 5/5 for my version, and push. > > Thanks, I will. > > Can you please remind me what the rules are regarding signatures? > Should I add your Signed-off-by, Reviewed-by, or anything else?
We don't really enforce any of that. You can add them if you like. > I'd think that since you've not only reviewed the patchset but also > built it and run against the testsuite SOB applies the best, but I > thought I'd better ask. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported. http://fedoraproject.org/wiki/MinGW _______________________________________________ Libguestfs mailing list Libguestfs@redhat.com https://www.redhat.com/mailman/listinfo/libguestfs
