On 15/06/16 16:56, Richard W.M. Jones wrote:
On Mon, Jun 13, 2016 at 07:50:52PM +0300, Matteo Cafasso wrote:
diff --git a/generator/structs.ml b/generator/structs.ml
index 6017ba6..3c2cc61 100644
--- a/generator/structs.ml
+++ b/generator/structs.ml
@@ -444,6 +444,19 @@ let structs = [
];
s_camel_name = "InternalMountable";
};
+
+ (* The Sleuth Kit directory entry information. *)
+ { defaults with
+ s_name = "tsk_dirent";
+ s_cols = [
+ "tsk_inode", FUInt64;
+ "tsk_type", FChar;
+ "tsk_size", FInt64;
+ "tsk_name", FString;
+ "tsk_flags", FUInt32;
Note if you ever need to add more columns in future, you won't be able
to, unless you reserve some space in the struct now by adding:
"tsk_spare1", FInt64;
"tsk_spare2", FInt64;
"tsk_spare3", FInt64;
"tsk_spare4", FInt64;
"tsk_spare5", FInt64;
"tsk_spare6", FInt64;
I can't say if you'll need more columns here, or if the set you have
now is the final set that you'll ever need.
I was wondering as actually there would be more information to report to
the users.
I'll reserve a bit of space just in case.
I will also apply the other suggested changes.
This patch looks OK to me.
Rich.
_______________________________________________
Libguestfs mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/libguestfs
