On 01/19/2018 09:06 AM, Richard W.M. Jones wrote:
> Commit 876d715e17a59bd25df53be34b942afd96e52da9
> ("Refactor plugin_* functions into a backend struct.") causes hidden
> crashes in the test suite (which unfortunately don't cause tests to
> fail).

Bummer about the non-failure in the testsuite making it harder to see
the problem.

> 
> These all come from handle_single_connection where we may lock the
> connection, run a single connection, free the backend, and then try to
> unlock the connection.  Unfortunately the unlock operation has to
> check the thread model again which fails because the backend has gone
> away:

Yep, makes sense.  Patch looks good to go.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
Libguestfs mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/libguestfs

Reply via email to