On Thu, Apr 05, 2018 at 03:03:41PM -0500, Eric Blake wrote:
> CentOS 6 has libguestfs-devel 1.20.11, which predates the support
> in guestfs_add_drive_opts() for requesting an nbd drive instead
> of a local file.  The guestfs plugin can still be built, so no
> configure changes are needed; but skip the tests that fail to
> compile so that 'make check' can at least complete.
> 
> Signed-off-by: Eric Blake <ebl...@redhat.com>


> +#ifndef GUESTFS_ADD_DRIVE_OPTS_PROTOCOL

There's a symbol defined for this kind of test:

#ifndef GUESTFS_HAVE_ADD_DRIVE_OPTS
  ...

(from <guestfs.h>).

However in this case I wonder if it would be better to test for this
in the ./configure script and disable the HAVE_LIBGUESTFS automake
conditional (but probably not error out -- we want to still compile on
RHEL 6).  What do you think?

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org

_______________________________________________
Libguestfs mailing list
Libguestfs@redhat.com
https://www.redhat.com/mailman/listinfo/libguestfs

Reply via email to