On Wed, Jun 06, 2018 at 01:48:56PM -0500, Eric Blake wrote: > On 06/06/2018 01:36 PM, Richard W.M. Jones wrote: > >Maybe a bug in libvirt? > >https://www.redhat.com/archives/libvir-list/2018-June/msg00490.html > > Or maybe intentional. Using absolute paths is better than assuming > that libvirt will treat relative paths against the same directory as > you intended; although it would be nicer if libvirt would reject XML > with a relative path up front rather than look in the wrong > directory and perhaps succeed by accident on the wrong file. > > >--- > > tests/test-cache.sh | 3 ++- > > tests/test-cow.sh | 3 ++- > > 2 files changed, 4 insertions(+), 2 deletions(-) > > >@@ -69,7 +70,7 @@ cleanup () > > trap cleanup INT QUIT TERM EXIT ERR > > # Open the overlay and perform some operations. > >-guestfish --format=raw -a 'nbd://?socket=cache.sock' <<'EOF' > >+guestfish --format=raw -a "nbd://?socket=`pwd`/cache.sock" <<'EOF' > > We're using bash, so save a fork, by using $PWD instead of `pwd`.
Thanks, I pushed it using $PWD and a more neutral commit message. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://libguestfs.org _______________________________________________ Libguestfs mailing list Libguestfs@redhat.com https://www.redhat.com/mailman/listinfo/libguestfs