On Thu, Sep 20, 2018 at 05:26:26PM +0200, Pino Toscano wrote: > On Thursday, 20 September 2018 12:15:12 CEST Richard W.M. Jones wrote: > > This would have been a bit easier to review if the keystore > > changes had been broken out from the tools changes. > > I actually thought (even too much) about various ways of splitting it; > since I wanted to not become a new Buridan's ass [1], then I lumped it > all in a single patch. > > Splitting is not an issue, so if you suggest a preferred layout I can > work on it.
Don't worry about it - it would have been easier, but I was able to review it anyway. I'd actually prefer if you pushed it as soon as possible so that I can do a new upstream release today. Also if you could look at the few patches I posted yesterday. Rich. > [1] https://en.wikipedia.org/wiki/Buridan%27s_ass > > > I think Eric's / qemu's shared key stuff sounds very complex, and I > > wonder who uses it. But in any case what you've proposed is > > extensible enough that we would be able to add other methods to pass > > the key in future. > > As I suggested in my reply to Eric's email, we can always create a "fd" > selector, if needed. > > -- > Pino Toscano > _______________________________________________ > Libguestfs mailing list > Libguestfs@redhat.com > https://www.redhat.com/mailman/listinfo/libguestfs -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into KVM guests. http://libguestfs.org/virt-v2v _______________________________________________ Libguestfs mailing list Libguestfs@redhat.com https://www.redhat.com/mailman/listinfo/libguestfs