On Fri, Nov 23, 2018 at 03:55:15PM +0100, Martin Kletzander wrote:
On Fri, Nov 23, 2018 at 02:26:08PM +0100, Martin Kletzander wrote:On Fri, Nov 23, 2018 at 01:16:55PM +0000, Richard W.M. Jones wrote:On Fri, Nov 23, 2018 at 02:10:01PM +0100, Martin Kletzander wrote:[...]I haven't find any unit tests for these kind of functions, so no tests are added. If there is a place where tests would fit nicely, feel free to let me know.... I think the tests might actually be broken by this patch. Did you try: ‘make -C test-data check && make -C v2v check’?good point, probably not after the patch. will do.The tests pass. Should I add/change something in there as well since I'm going to be sending v2 anyway?
My bad, I had the appliance and daemon disabled. I'll build with that and update the patch accordingly, sorry for the noise.
[...]But I just noticed I forgot to differentiate SLED from SLES. It should be possible based on i_product_name. I think it would make sense for libosinfo and it doesn't look like they are separate in libguestfs (on purpose). Would it also make sense to separate them here? Is it even possible? I'm not sure what the compatibility promises are.No idea. We just try to provide libvirt XML which is as useful as possible.I added SLED/SLES differentiation to v2.
signature.asc
Description: Digital signature
_______________________________________________ Libguestfs mailing list [email protected] https://www.redhat.com/mailman/listinfo/libguestfs
