On Fri, Feb 08, 2019 at 08:53:44AM -0600, Eric Blake wrote: > > +++ b/plugins/rust/Cargo.toml.in > > @@ -0,0 +1,14 @@ > > +[package] > > +name = "nbdkit" > > +version = "@VERSION@" > > +authors = ["Richard W.M. Jones <[email protected]>"] > > +edition = "2018" > > 2019? Some form of @YEAR@ to make it auto-update from configure results?
I think 2018 here refers to the version of Rust that it's compatible with: https://doc.rust-lang.org/beta/cargo/reference/manifest.html In any case 2018 was inserted by ‘cargo new’ (even though it's 2019) so I guess they know what they're doing :-) > > +++ b/plugins/rust/examples/ramdisk.rs > > > > + > > +// Every plugin must define a public, C-compatible plugin_init > > +// function which returns a pointer to an Plugin struct. > > s/an Plugin/a Plugin/ You can tell the struct used to be called NBDKitPlugin, until I worked out about module namespaces. Thanks, I pushed it. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://libguestfs.org _______________________________________________ Libguestfs mailing list [email protected] https://www.redhat.com/mailman/listinfo/libguestfs
