On Thu, Jun 27, 2019 at 05:06:02PM +0900, Hiroyuki Katsura wrote: > diff --git a/generator/bindtests.ml b/generator/bindtests.ml > index 58d7897b3..41aef47ea 100644 > --- a/generator/bindtests.ml > +++ b/generator/bindtests.ml > @@ -983,6 +983,9 @@ and generate_php_bindtests () = > > dump "bindtests" > > +and generate_rust_bindtests () = > + generate_header CStyle GPLv2plus;
There is an extra ‘;’ here which is wrong and I'm a bit surprised that it doesn't confuse the compiler too. Just delete the semicolon. > diff --git a/generator/rust.ml b/generator/rust.ml > new file mode 100644 > index 000000000..83afdfe73 > --- /dev/null > +++ b/generator/rust.ml > @@ -0,0 +1,34 @@ > +(* libguestfs > + * Copyright (C) 2019 Red Hat Inc. > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 > USA > +*) > + > +(* Please read generator/README first. *) > + > +open Std_utils > +open Types > +open Utils > +open Pr > +open Docstrings > +open Optgroups > +open Actions > +open Structs > +open C > +open Events > + > + Extra blank line above - please remove it. > +let generate_rust () = > + generate_header CStyle LGPLv2plus; > \ No newline at end of file The extra semicolon here could be dropped, and you could add a newline at the end of the file too. --- Apart from those things, this patch is fine. I would ACK it if you fixed these. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html _______________________________________________ Libguestfs mailing list Libguestfs@redhat.com https://www.redhat.com/mailman/listinfo/libguestfs
