This is not intended for v1.14. In fact, we may decide that the second patch is too gross, although the first one still seems like a useful improvement in isolation.
I will also point out that all our filters are in-tree, and set the user-controlled field .version to the current release string. We could replace the second patch with a simpler one that just checks ._api_version as an int (as before), but adds the additional requirement that .version match PACKAGE_VERSION from config.h. Then we don't have to hack around ABI changes of the first field member, but are slightly more protected if we forget to bump ._api_version in the future. Eric Blake (2): include: Expose nbdkit version information to public filters: Stronger version match requirements configure.ac | 15 ++++++++++++- server/filters.c | 32 +++++++++++++++++++++----- include/nbdkit-common.h | 2 ++ include/nbdkit-filter.h | 10 ++++----- .gitignore | 1 + include/Makefile.am | 1 + include/nbdkit-version.h.in | 45 +++++++++++++++++++++++++++++++++++++ 7 files changed, 93 insertions(+), 13 deletions(-) create mode 100644 include/nbdkit-version.h.in -- 2.21.0 _______________________________________________ Libguestfs mailing list [email protected] https://www.redhat.com/mailman/listinfo/libguestfs
