On Thu, Apr 23, 2020 at 02:49:25PM +0100, Daniel P. Berrangé wrote: > I think this design with two interfaces looks pretty nice from the > Go plugin implementors POV now.
Thanks. While implementing PWrite I discovered that C.GoBytes makes a copy (the docs were unclear on this), so it wasn't actually reading and writing from the server at all :-( All fixed now after reading this very long issue: https://github.com/golang/go/issues/13656 Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into KVM guests. http://libguestfs.org/virt-v2v _______________________________________________ Libguestfs mailing list Libguestfs@redhat.com https://www.redhat.com/mailman/listinfo/libguestfs