Trivial fix. We really need a regression test for all v2v inpus related to nbdkit. There is actually nothing at all at the moment. Of course if it was easy to test inputs over the network from a ‘make check’ rule then we'd be doing it already.
I thought about adding something like a ‘-it file’ option which would use nbdkit-file-plugin for test only. However I'm rather cautious about adding new virt-v2v command line features, especially dubious do-nothing features, when my longer term plan is to break apart virt-v2v into more easily consumable pieces. That will only make the long term plan more difficult. We could probably test ‘-it ssh’ using the same trick that nbdkit uses (https://github.com/libguestfs/nbdkit/blob/master/tests/web-server.h#L33) but even that is not straightforward as ‘-it ssh’ also wants to run scp commands. So that's a long way of saying this fixes the code but doesn't add a regression test. Rich. _______________________________________________ Libguestfs mailing list [email protected] https://www.redhat.com/mailman/listinfo/libguestfs
